-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View entity to fetch eligible records #2
base: main
Are you sure you want to change the base?
View entity to fetch eligible records #2
Conversation
…b.com/Shinde-nutan/mantle-net-suite-connector into view-entity-to-fetch-eligible-records
… OADJ from the OrderItemsForNetSuiteView
…b.com/Shinde-nutan/mantle-net-suite-connector into view-entity-to-fetch-eligible-records
…y check from the main view
it can be shifted into oms-udm later.
<key-map field-name="partyId"/> | ||
<entity-condition> | ||
<econdition entity-alias="PID" field-name="partyIdentificationTypeId" value="NETSUITE_CUSTOMER_ID"/> | ||
</entity-condition> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shinde-nutan,
Add one more entity condition to include "SHOPIFY_CUST_ID"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello sir,
In this view we are fetching the details which is required for an order to sync at Netsuite.
the shopify customer id is not required field. if needed we can add that in the custom groovy file which we are preparing specific to client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we will have Shopify as a constant in our integrations, fetching the field in this view will make this specific to Shopify only and create need for refactoring should orders enter HotWax from another source. For now I agree with @Shinde-nutan here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dt2patel
I agreed.
During the KR Production rollout, someone enabled the "Import Customer Job," which resulted in duplicate customers being created in NetSuite. When we create customers through the "Import Customer Job," we store the Shopify Customer ID in the External ID field of the Party entity.
However, when syncing historical customers from NetSuite or importing a new order from Shopify, we create a PartyIdentification record with the Shopify Customer ID and the corresponding partyIdentificationTypeID defined in OMS.
To avoid duplication issues, we need to add a condition to filter valid customer records appropriately during the fetch process. So we can add the condition in the Groovy file.
CC: @Shinde-nutan
…ck on shipping method while fetching the eligible orderIds
… orders from the EligibleOrdersForNetSuiteView view.
Added two views in the component
OrderItemsForNetSuiteView
view is to fetch order item-level details that are required for creating the order feed from Hotwax to NetSuite.